bazel icon indicating copy to clipboard operation
bazel copied to clipboard
verified publisher icon bazelbuild

python: Ignore SIGINT while running wrapped program from zip

Open bubski opened this issue 2 years ago • 5 comments

This is a proposal to resolve https://github.com/bazelbuild/bazel/issues/20255

python_bootstrap_template has been updated to ignore SIGINT while the wrapped program is running, to not interfere with its potential custom handling.

bubski avatar Nov 17 '23 22:11 bubski

👋 @iancha1992 I'm not sure who to reach out to. Could you help me find someone who could take a look at this? Thank you!

bubski avatar Feb 20 '24 18:02 bubski

cc: @fmeum @rickeylev

iancha1992 avatar Feb 20 '24 20:02 iancha1992

👋 @fmeum @rickeylev would either of you have the time to see if what I'm suggesting is reasonable?

bubski avatar Apr 17 '24 22:04 bubski

@aignas Could you take over here?

fmeum avatar Apr 27 '24 10:04 fmeum

This looks like a reasonable change, could you create a PR against the bootstrap template that is in the rules_python please? The latest versions of rules_python use the copy that is there.

It would be also great if we could add a test to check the behaviour. If I understand correctly, we could create a special py_binary that could be invoked it py_test via subprocess.

aignas avatar Apr 27 '24 12:04 aignas