bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Allow use scrubbing with remote execution (build actions with scrubbed inputs locally)

Open bozaro opened this issue 1 year ago • 2 comments

Since cannot run remote cache key scrubbing action with remote execution, run this actions only locally. Actions without scrubbed input can still be executed remotely.

Same idea as:

  • https://github.com/bazelbuild/bazel/pull/16240

bozaro avatar Nov 07 '23 14:11 bozaro

This PR works fine on release-7.0.0rc2 and bozaro:scrubbing-with-remote-execution branches, but on 7.0.0 tag it's requre patch like https://github.com/joomcode/bazel/commit/663beb61e4e7c8f708d3e058a670cc977d6a1362 (produced by cherry-pick https://github.com/bazelbuild/bazel/commit/2b700b5108e9969511ab8defe6612b5a50b4df86 after bisect between 7.0.0 and bozaro:scrubbing-with-remote-execution).

The check seems to ignore transitive dependencies:

    var inputFiles = spawn.getInputFiles();
    for (ActionInput inputFile : inputFiles.getLeaves()) {
      if (spawnScrubber.shouldOmitInput(inputFile)) {
        return true;
      }
    }

bozaro avatar Jan 11 '24 05:01 bozaro

I am sorry... Rebasing to 7.0.0 tag was a bad idea...

bozaro avatar Jan 11 '24 08:01 bozaro