bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Release 5.3 - August 2022

Open ckolli5 opened this issue 2 years ago • 10 comments

Status of Bazel 5.3

To report a release-blocking bug, please add a comment with the text @bazel-io flag to the issue. A release manager will triage it and add it to the milestone.

To cherry-pick a mainline commit into 5.3, simply send a PR against the release-5.3.0 branch.

Task list:

ckolli5 avatar Jun 15 '22 18:06 ckolli5

Hello :wave: general question on release cadence - https://github.com/bazelbuild/bazel/issues/15682 is a bug in 5.2.0. Should it be picked into a 5.2.x patch release, or is 5.3.0 is the patch release? Just wanted to make sure whichever release it lands only contains the bug fixes, and no new development.

wisechengyi avatar Jul 13 '22 06:07 wisechengyi

Hello - there is a ticket https://github.com/bazelbuild/bazel/issues/15762 .Are you also planning to pick it for the next patch release

ananta-code avatar Jul 13 '22 13:07 ananta-code

Hello 👋 general question on release cadence - #15682 is a bug in 5.2.0. Should it be picked into a 5.2.x patch release, or is 5.3.0 is the patch release? Just wanted to make sure whichever release it lands only contains the bug fixes, and no new development.

@wisechengyi We have already cherry picked the fix that is addressing this issue to release-5.3.0. At this point we are not planing to perform any patch release.

ckolli5 avatar Jul 21 '22 20:07 ckolli5

Hello - there is a ticket #15762 .Are you also planning to pick it for the next patch release

@ananta-code Since we are not planing for any patch release at this point, this will be cherry picked to release-5.3.0.

ckolli5 avatar Jul 21 '22 20:07 ckolli5

I was wondering if a change like https://github.com/bazelbuild/bazel/commit/d7f0724b6b91b6c57039a1634ff00ccebd872714 would be considered too disruptive have left for Bazel 6.x or if it's ok to be considered for 5.3?

cc: @wilwell

sluongng avatar Jul 25 '22 14:07 sluongng

Context: we recently run into an issue where we have a lot of rules_docker actions that zip/tar large blobs of container images. These actions can be quite expensive in memory consumption and require fine tuning to avoid they all run in parallel together, which trigger kernel's OOM killer.

Having resource_set in 5.3 would allow us to do exactly that.


Edit: created https://github.com/bazelbuild/bazel/pull/15968 to discuss this

Edit2: it seems like the change was included as part of this squashed commit https://github.com/bazelbuild/bazel/commit/78af34f9f25b0c8fbf597a794a5162f0014629c5

Sorry for the noise, thanks for the amazing work 🙇‍♂️

sluongng avatar Jul 25 '22 14:07 sluongng

Hello all, we have decided to push the release date to 08/15/2022. Just wanted to keep you all updated. Thanks!

ShreeM01 avatar Jul 25 '22 20:07 ShreeM01

Ran 5.3 RC1 on our build against our remote execution cluster and it fails to run tests. https://github.com/bazelbuild/bazel/issues/16003 is the bug I filed. This is a regression from 5.0, which worked with the exact same version of the code being built and the exact same command.

AustinSchuh avatar Jul 29 '22 23:07 AustinSchuh

Hello, would it be possible to cherry-pick https://github.com/bazelbuild/bazel/commit/9c98120f33579b72561e02826d9fccf222eccb3c (https://github.com/bazelbuild/bazel/issues/15130) for 5.3?

UebelAndre avatar Aug 04 '22 16:08 UebelAndre

Ran 5.3 RC1 on our build against our remote execution cluster and it fails to run tests. #16003 is the bug I filed. This is a regression from 5.0, which worked with the exact same version of the code being built and the exact same command.

Hi @AustinSchuh, we are awaiting review on 16008 which fixes the issue.

ShreeM01 avatar Aug 04 '22 20:08 ShreeM01

Ran 5.3 RC1 on our build against our remote execution cluster and it fails to run tests. #16003 is the bug I filed. This is a regression from 5.0, which worked with the exact same version of the code being built and the exact same command.

Ran 5.3 RC1 on our build against our remote execution cluster and it fails to run tests. #16003 is the bug I filed. This is a regression from 5.0, which worked with the exact same version of the code being built and the exact same command.

Hi @AustinSchuh, we are awaiting review on 16008 which fixes the issue.

Ran 5.3 RC1 on our build against our remote execution cluster and it fails to run tests. #16003 is the bug I filed. This is a regression from 5.0, which worked with the exact same version of the code being built and the exact same command.

Hi @AustinSchuh, we are awaiting review on 16008 which fixes the issue.

Hello @AustinSchuh! Just an update, as 16008 fixes the issue, it has been reviewed and merged to release 5.3.0. Thanks!

ShreeM01 avatar Aug 10 '22 17:08 ShreeM01

I would like to put forward https://github.com/bazelbuild/bazel/pull/16095 a trivial change to add support for java language level 17 to the linux-aarch64 platform

nresare avatar Aug 12 '22 14:08 nresare

I would like to put forward #16095 a trivial change to add support for java language level 17 to the linux-aarch64 platform

Hello @nresare, Just to let you know it is not possible for this release-5.3.0. We can pick it in next release. Thanks!

ShreeM01 avatar Aug 16 '22 14:08 ShreeM01

Will there be a 5.3.0rc2 before the final release?

dws avatar Aug 16 '22 15:08 dws

Will there be a 5.3.0rc2 before the final release?

Hi @dws! yes, we are going to announce 5.3.0rc2 before the final release. Thanks!

ShreeM01 avatar Aug 16 '22 17:08 ShreeM01

I would like to put forward #16095 a trivial change to add support for java language level 17 to the linux-aarch64 platform

Hello @nresare, Just to let you know it is not possible for this release-5.3.0. We can pick it in next release. Thanks!

I see. Is there a branch cut for this next release, to open PRs against?

nresare avatar Aug 17 '22 09:08 nresare

I would like to put forward #16095 a trivial change to add support for java language level 17 to the linux-aarch64 platform

Hello @nresare, Just to let you know it is not possible for this release-5.3.0. We can pick it in next release. Thanks!

I see. Is there a branch cut for this next release, to open PRs against?

Hi @nresare! Not as of yet, we will be cutting the branch for next release after this release. Thanks!

ShreeM01 avatar Aug 17 '22 16:08 ShreeM01

5.3 is now out!

@petemounce @excitoon @vbatts Could you please update relevant package managers? Thanks!

ShreeM01 avatar Aug 23 '22 13:08 ShreeM01

Hello - there is a ticket #15762 .Are you also planning to pick it for the next patch release

@ananta-code Since we are not planing for any patch release at this point, this will be cherry picked to release-5.3.0.

@ckolli5 I don't see this listed in the 5.3 release notes. Can you confirm the fix has been included? Both #15762 and #15865 are still open.

dan-cohn-sabre avatar Aug 23 '22 15:08 dan-cohn-sabre

https://github.com/bazelbuild/bazel/pull/16008#issuecomment-1224267553 is a first report of a 5.3.0 regression my fix for #16003 introduced - the existing tests didn't cover local execution.

fmeum avatar Aug 23 '22 16:08 fmeum

Hello - there is a ticket #15762 .Are you also planning to pick it for the next patch release

@ananta-code Since we are not planing for any patch release at this point, this will be cherry picked to release-5.3.0.

@ckolli5 I don't see this listed in the 5.3 release notes. Can you confirm the fix has been included? Both #15762 and #15865 are still open.

Hi @dan-cohn-sabre! As we are working on it, we will keep you updated of any progress. Thanks!

ShreeM01 avatar Aug 24 '22 17:08 ShreeM01

Hello - there is a ticket #15762 .Are you also planning to pick it for the next patch release

Hi @ananta-code ! As this issue is marked as P3, we don't have any resource to work on this. Please feel free to send PR. Thanks!

ShreeM01 avatar Sep 07 '22 17:09 ShreeM01

5.3.1 is now out!

@vbatts @petemounce @excitoon Could you please update relevant package managers? Thanks!

ShreeM01 avatar Sep 21 '22 17:09 ShreeM01

Done, both; apologies for delay.

@kshyanashree - who can I talk to to integrate the chocolatey build & push into bazel CI? It requires:

  • a windows CI node (which I believe isn't a problem nowadays)

  • a person inside the bazel team to have access to the chocolatey bazel profile

  • that person to create and securely save a chocolatey API key for use within CI

  • that person to teach said windows CI node where to acquire said API key from secure storage

  • a tiny trivial CI job which runs after the release has been pushed to github that does

    # {inside a bazelbuild/bazel clone's checkout}
    cd "scripts/packaging/chocolatey"
    ./build.ps1 -version "VERSION" -mode "release"
    choco push
    

petemounce avatar Oct 03 '22 19:10 petemounce

@meteorcloudy FYI, we could maybe look into this

Wyverald avatar Oct 04 '22 10:10 Wyverald

@petemounce Thanks! I filed an issue to track this: https://github.com/bazelbuild/continuous-integration/issues/1456

meteorcloudy avatar Oct 04 '22 11:10 meteorcloudy

5.3.2 is now out!

@petemounce @excitoon @vbatts Could you please update relevant package managers? Thanks!

ShreeM01 avatar Oct 19 '22 20:10 ShreeM01

Done. Ping on https://github.com/bazelbuild/continuous-integration/issues/1456

petemounce avatar Oct 20 '22 08:10 petemounce

#15762

Hi , I can see https://github.com/bazelbuild/bazel/issues/15762 is showing as closed but https://github.com/bazelbuild/bazel/issues/15865 is still open . Could you please check?

ananta-code avatar Jul 19 '23 06:07 ananta-code