bazel-toolchains icon indicating copy to clipboard operation
bazel-toolchains copied to clipboard

4.2.x release

Open keith opened this issue 3 years ago • 3 comments

Will there be a 4.2.x release to silence the warnings when using this repo?

keith avatar Aug 27 '21 05:08 keith

cc @philwo since you did the last one :pray:

keith avatar Sep 10 '21 23:09 keith

Hi @keith,

I looked into the cause of this warning and it seems like it's related to the Bazel version installed in the rbe-ubuntu16-04 container:

  • version_check.bzl prints the warning message if native.bazel_version > bazel_version_fallback: https://github.com/bazelbuild/bazel-toolchains/blob/4.1.0/rules/rbe_repo/version_check.bzl#L66-L70
  • bazel_version_fallback is passed in here from a global constant _BAZEL_VERSION_FALLBACK: https://github.com/bazelbuild/bazel-toolchains/blob/4.1.0/rules/rbe_repo.bzl#L1059-L1063
  • _BAZEL_VERSION_FALLBACK is defined to be equal to BAZEL_LATEST here: https://github.com/bazelbuild/bazel-toolchains/blob/4.1.0/rules/rbe_repo.bzl#L457-L458
  • BAZEL_LATEST is loaded from an ubuntu1604.bzl here: https://github.com/bazelbuild/bazel-toolchains/blob/4.1.0/rules/rbe_repo.bzl#L400-L403
  • Which has the BAZEL_LATEST defined as 4.0.0: https://github.com/bazelbuild/bazel-toolchains/blob/4.1.0/configs/dependency-tracking/ubuntu1604.bzl#L2

As the release infrastructure for the old bazel-toolchains and the rbe-ubuntu16-04 container is gone or at least we don't know anything about it, we can't update this "the right way". 😬

If it helps, I could make a bazel-toolchains patch release that just removes that warning message.

philwo avatar Sep 13 '21 10:09 philwo

Yea I guess considering master doesn't have that warning that would be ideal. The project I'm looking at uses the .bazelrc configs, but doesn't actually care about the rules that have since been removed

keith avatar Sep 13 '21 16:09 keith