bazel-skylib icon indicating copy to clipboard operation
bazel-skylib copied to clipboard

Add ‘paths.relative_path’ function

Open mrkkrp opened this issue 6 years ago • 5 comments

This is a function that we found ourselves needing sometimes.

mrkkrp avatar May 15 '18 09:05 mrkkrp

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar May 15 '18 09:05 googlebot

CLAs look good, thanks!

googlebot avatar May 15 '18 09:05 googlebot

Related: https://github.com/bazelbuild/bazel-skylib/issues/30.

mboes avatar Jun 09 '18 12:06 mboes

This seems to have gone stale? Is it going to move forward or should we close it.

aiuto avatar Mar 19 '19 02:03 aiuto

Is there a chance of this getting reviewed and merged? I just wrote an almost identical function in starlark for some rules this afternoon because I didn't find it in Skylib - would have been nice if it were available :)

tetromino avatar Jan 28 '21 03:01 tetromino