bazel-central-registry
bazel-central-registry copied to clipboard
wanted: osqp-eigen
Module location
https://github.com/robotology/osqp-eigen
Link to bzlmod issue in the module's repository
No response
Any other context to provide?
No response
Fund our work
- [ ] Sponsor our community's open source work by donating a feature bounty
I looked into this in https://github.com/bazelbuild/bazel-central-registry/discussions/3353 but I am not a bazel expert, so if you have any suggestion feel free to weigh in!
I looked into this in #3353 but I am not a bazel expert, so if you have any suggestion feel free to weigh in!
Happy to contribute. Those linker errors are strange indeed.
I have a BUILD.bazel file that looks like this, which I have been using for quite some time:
cc_library(
name = "osqp-eigen",
srcs = glob(["src/*.cpp"]),
hdrs = glob([
"include/OsqpEigen/*.h",
"include/OsqpEigen/*.hpp",
"include/OsqpEigen/*.tpp",
]),
defines = [
# Uncomment this to enable debug printing for testing.
#"OSQP_EIGEN_DEBUG_OUTPUT",
"OSQP_EIGEN_OSQP_IS_V1",
],
includes = ["include"],
visibility = ["//visibility:public"],
deps = [
"@eigen",
"@osqp",
],
)
It's worth saying that I am using the latest version on main for both osqp and osqp-eigen. I had issues which I can't remember now when using the latest osqp release (which is quite old now).
I just had a look at the osqp BUILD.bazel file in bcr, and it does look like some issues might need to be addressed there.
I'm happy to take a look, but I'd rather use the latest commit on main because they cleaned up a lot of stuff since the 0.6.3 release.
Unfortunately, they haven't release v1.0 yet.
What would be the protocol for me to release a version to BCR, which is just a commit hash from main? Is that allowed, or should I keep this internal to my own repo until they publish a formal release upstream?
Now, osqp 1.0 has been released. I'll try to add it into bcr, first.
Thanks @wep21 ! If there is anything do you think it make sense to have in osqp-eigen upstream let us know, I would love to understand how to properly support bazel/bazel-central-registry in the C++ libraries we mantain.