bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

[email protected]

Open publish-to-bcr-bot[bot] opened this issue 10 months ago • 16 comments

Release: https://github.com/benchsci/rules_nodejs_gazelle/releases/tag/v0.7.0

Automated by Publish to BCR

publish-to-bcr-bot[bot] avatar Apr 23 '24 19:04 publish-to-bcr-bot[bot]

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (com_github_benchsci_rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 23 '24 19:04 bazel-io

@ewianda @ColinHeathman

Can you please rebase this PR to HEAD to get fixes from https://github.com/bazelbuild/bazel-central-registry/pull/1866?

Also, is it intentional to call this module com_github_benchsci_rules_nodejs_gazelle instead of rules_nodejs_gazelle? FYI @alexeagle

meteorcloudy avatar Apr 24 '24 10:04 meteorcloudy

@ewianda @ColinHeathman

Can you please rebase this PR to HEAD to get fixes from #1866?

Also, is it intentional to call this module com_github_benchsci_rules_nodejs_gazelle instead of rules_nodejs_gazelle? FYI @alexeagle

@meteorcloudy what will be the process of renaming the module

ewianda avatar Apr 24 '24 15:04 ewianda

what will be the process of renaming the module

Just change it in your MODULE.bazel file and the entry name used in this PR.

meteorcloudy avatar Apr 24 '24 15:04 meteorcloudy

Hello @alexeagle, modules you maintain (aspect_rules_lint) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @dzbarsky, modules you maintain (aws-in-a-box) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @aherrmann, modules you maintain (rules_zig) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @morambro, modules you maintain (tink_cc) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @zadlg, modules you maintain (tree-sitter-c-bazel) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bzip2, rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 24 '24 16:04 bazel-io

hi @meteorcloudy I am stuck with trying to rename the module Can you advice on how to fix this

ewianda avatar Apr 25 '24 11:04 ewianda

You have to fix https://github.com/benchsci/rules_nodejs_gazelle/blob/6542264ecb383191380918978d11b2ea3e8a450e/examples/nextjs/MODULE.bazel#L13-L17, which probably need a new patch release.

meteorcloudy avatar Apr 25 '24 12:04 meteorcloudy

@meteorcloudy we have decided to keep the original module name

ewianda avatar Apr 26 '24 12:04 ewianda

Can you please check the windows failure?

meteorcloudy avatar Apr 26 '24 12:04 meteorcloudy

@meteorcloudy can you please take a look

ewianda avatar Apr 30 '24 12:04 ewianda

@alexeagle @meteorcloudy can I please get this reviewed

ewianda avatar May 06 '24 14:05 ewianda

Sorry for the delays! Notifications in this repo has gotten a bit out of hand with all the C++ projects being added.

alexeagle avatar May 06 '24 15:05 alexeagle