bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

[email protected]

Open mmorel-35 opened this issue 10 months ago • 6 comments

Release: https://github.com/googleapis/google-cloud-cpp/releases/tag/v2.16.0

Used by:

  • https://github.com/grpc/grpc

mmorel-35 avatar Apr 13 '24 11:04 mmorel-35

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (google-cloud-cpp) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 13 '24 11:04 bazel-io

There is at least two problems here :

ERROR: file:///Users/buildkite/builds/bk-macstudio-10/bazel/bcr-presubmit/modules/rules_jvm_external/6.0/MODULE.bazel:65:13: name 'use_repo_rule' is not defined
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> [email protected] -> [email protected] -> [email protected] -> [email protected]: error executing MODULE.bazel file for [email protected]

googleapis seems incompatible with bazel 6

The other is

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel: no such target '@@googleapis~//:googleapis_system_includes': target 'googleapis_system_includes' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/google-cloud-cpp~/google/cloud/BUILD.bazel:176:11: no such target '@@googleapis~//:googleapis_system_includes': target 'googleapis_system_includes' not declared in package '' defined by /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/10a664a2543b3806f216749be8556dd8/external/googleapis~/BUILD.bazel and referenced by '@@google-cloud-cpp~//google/cloud:google_cloud_cpp_grpc_utils_private'

googleapis version doesn't have the googleapis_system_includes target

@keith , would you be able to provide some assistance on those as you provided googleapis module in the BCR ?

mmorel-35 avatar Apr 13 '24 12:04 mmorel-35

Anything that depends on the newest rules_jvm_external transitively requires bazel 7. I didn't investigate how reasonable it would be to workaround.

On the missing target issue is it because of a version expectation mismatch? Or is that one more recent than the BCR upload?

keith avatar Apr 13 '24 13:04 keith

2.16.0 is not the most recent version of google cloud cpp so it’s probably better to try with the most recent I guess but as grpc is using this one I tried to aligned with it

mmorel-35 avatar Apr 13 '24 13:04 mmorel-35

i would toss the bazel 6.x from CI here, then it looks like the errors on 7.x are real

keith avatar May 06 '24 20:05 keith

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (google-cloud-cpp) have been updated in this PR. Please review the changes.

bazel-io avatar May 07 '24 08:05 bazel-io