bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

Add glm 1.0.1

Open Vertexwahn opened this issue 11 months ago • 5 comments

Add glm 1.0.1

Vertexwahn avatar Feb 28 '24 20:02 Vertexwahn

Hello @phaedon, modules you maintain (glm) have been updated in this PR. Please review the changes.

bazel-io avatar Feb 28 '24 20:02 bazel-io

@phaedon I think it works now...

Vertexwahn avatar Mar 06 '24 21:03 Vertexwahn

Hello @phaedon, modules you maintain (glm) have been updated in this PR. Please review the changes.

bazel-io avatar Mar 16 '24 15:03 bazel-io

Need skip-url-stability-check label (do not use anymore the light archive - since this archive does not include tests - the light archive had a stable hash - the archive with test unfortunately not)

Vertexwahn avatar Mar 16 '24 16:03 Vertexwahn

@phaedon I switched to the "full" archive of glm (since that has a test folder) - but I see no possibility to test if includes of glm headers using angles brackets work.

Since I have + includes = ["."], I can not execute bazel test //.... because a Bazel project cannot include its own root dir (Bazel violation). Therefore, my patch file creates a .bazelignore file to ignore the test folder and creates in the test folder a new Bazel workspace/module that references the parent dir via:

+local_path_override(
+    module_name = "glm",
+    path = "..",
+)

but this would require me to run tests in the folder "test" - but this seems not to work with the presubmit... not sure how to go on from here - maybe I drop the tests again...

I have a copy of my "bazelized" version of glm-1.0.1 here

Vertexwahn avatar Mar 16 '24 18:03 Vertexwahn