bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

[email protected]

Open aaronmondal opened this issue 11 months ago • 4 comments

aaronmondal avatar Feb 27 '24 01:02 aaronmondal

Hello @Vertexwahn, modules you maintain (zlib-ng) have been updated in this PR. Please review the changes.

bazel-io avatar Feb 27 '24 01:02 bazel-io

@Wyverald Thanks for taking a look. I removed the unnecessary files. The previous patch was just created with git show > xxx.patch, but for some reason the patch file format was invalid (CI said "can't patch WORKSPACE.bazel").

I removed the redundant files and used a git diff > xxx.patch instead.

aaronmondal avatar Feb 27 '24 12:02 aaronmondal

@Wyverald Ah I believe the reason the patch failed was that the WORKSPACE.bzlmod didn't contain any content, and so the info

--- /dev/null
+++ b/WORKSPACE.bzlmod

wasn't part of the patch. I added an empty line. That should fix it.

aaronmondal avatar Mar 01 '24 14:03 aaronmondal

@aaronmondal Windows is failing.

fmeum avatar Mar 01 '24 17:03 fmeum