bazel-buildfarm icon indicating copy to clipboard operation
bazel-buildfarm copied to clipboard

Update ingress.yaml

Open alexiscarbillet opened this issue 1 year ago • 3 comments
trafficstars

Hello,

I am adding "-server" in the pathType. It is needed for the ingress to work

alexiscarbillet avatar Apr 19 '24 15:04 alexiscarbillet

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 19 '24 15:04 google-cla[bot]

Not sure I follow. The pathType is one of ImplementationSpecific, Exact, or Prefix. The value is set by the user in the applied Values when u enable Ingress. https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types

andrewrothstein avatar Apr 19 '24 20:04 andrewrothstein

Hello,

Sorry I changed the wrong line at first, I just committed again. I added more information for my case:

server: ingress: enabled: true hosts: - host: bazel.com paths: - path: / pathType: ImplementationSpecific

For the ingress, I get this error │ Rules: │ │ Host Path Backends │ │ ---- ---- -------- │ │ bazel.com │ │ / bazel-buildfarm:8980 (<error: endpoints "bazel-buildfarm" not found>) │ │ Annotations: meta.helm.sh/release-name: bazel-buildfarm │ │ meta.helm.sh/release-namespace: bazel-buildfarm

while the service created is named: │ Name: bazel-buildfarm-server │ │ Namespace: bazel-buildfarm │

I tried with pathType: Prefix but I have the same error. However with the patch it works

alexiscarbillet avatar Apr 22 '24 13:04 alexiscarbillet

please rebase

andrewrothstein avatar May 03 '24 13:05 andrewrothstein

@andrewrothstein can you review since push?

werkt avatar May 24 '24 16:05 werkt

LGTM

andrewrothstein avatar May 27 '24 02:05 andrewrothstein