apple_support icon indicating copy to clipboard operation
apple_support copied to clipboard

Allows to provide Lipo tool location via custom toolchain.

Open DmitriiTcimbal opened this issue 1 year ago • 1 comments

There might be cases when universal_binary rule has to be used in the absence of a local Xcode/CLT installation. This MR allows the location of the Lipo tool to be provided via the custom toolchain.

DmitriiTcimbal avatar Jun 19 '24 01:06 DmitriiTcimbal

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 19 '24 01:06 google-cla[bot]

I don't think it's possible to use this rule without xcode installed since it relies on this? https://github.com/bazelbuild/apple_support/blob/19cbebf9332fc78f67d03592aad15c300f846c23/lib/apple_support.bzl#L223

keith avatar Jul 05 '25 16:07 keith

I think im wrong about that and it must be a no-op for linux at the very least. at first i wasn't thinking we should merge this but i've since seen that grpc started using this rule, and if you want to avoid major xcode version dependence you need this, so i think we should probably move forward with it. can you rebase and sign the CLA?

keith avatar Jul 17 '25 23:07 keith