BUILD_file_generator icon indicating copy to clipboard operation
BUILD_file_generator copied to clipboard

Tests are failing with JDK 11

Open meteorcloudy opened this issue 5 years ago • 6 comments

https://buildkite.com/bazel/build-file-generator/builds/93

There was 1 failure:
1) ruleKindDetection(com.google.devtools.build.bfg.JavaSourceFileParserTest)
java.lang.AssertionError: Not true that <[/src/x/Binary.java=java_library, /src/x/SomeTest.java=java_test, /src/x/AbstractTest.java=java_library]> contains exactly <[/src/x/Binary.java=java_binary, /src/x/SomeTest.java=java_test, /src/x/AbstractTest.java=java_library]>. It is missing <[/src/x/Binary.java=java_binary]> and has unexpected items <[/src/x/Binary.java=java_library]>

/cc @philwo @greggdonovan

meteorcloudy avatar May 07 '19 09:05 meteorcloudy

The project is disabled in Bazel's downstream test due to this issue, please help fixing.

meteorcloudy avatar May 15 '19 09:05 meteorcloudy

@cgrushko @petroseskinder

meteorcloudy avatar May 15 '19 09:05 meteorcloudy

@greggdonovan @petroseskinder ptal as you are listed as CODEOWNERS.

If the project is unmaintained, I would rather mark it as such and archive the GitHub repo.

dslomov avatar May 28 '19 12:05 dslomov

@dslomov I don't think either @petroseskinder or I are actively working on the project. I'm fine with archiving the project.

greggdonovan avatar May 28 '19 16:05 greggdonovan

Thanks for the update!

If I don't hear back from @petroseskinder until Monday, I'll archive this project then and will remove it from CI. We can always unarchive it again, in case someone wants to take up the work on this in the future.

philwo avatar May 29 '19 11:05 philwo

I'm archiving this now.

philwo avatar Jun 04 '19 11:06 philwo