BUILD_file_generator icon indicating copy to clipboard operation
BUILD_file_generator copied to clipboard

Adding graph nodes for all targets found to ensure that BUILD files a…

Open greggdonovan opened this issue 7 years ago • 2 comments

…re generated for disconnected targets.

greggdonovan avatar Dec 01 '17 18:12 greggdonovan

This PR would fix a bug where we didn't generate rules for java files without any dependency edges, right? EDIT: if that's the case, might be worth calling this out explicitly in the commit message.

cgrushko avatar Dec 04 '17 23:12 cgrushko

@cgrushko That's exactly right. E.g.: in the "Hello, world" e2e test there's only 1 target, so there are no edges. Without a node for that single target, no BUILD files are generated.

greggdonovan avatar Dec 05 '17 01:12 greggdonovan