xchammer

xchammer copied to clipboard

In Bazel, a `resource` or `structured_resource` can very well be an artifact. In the case of `XCHammer->XCHammer`. For a good test case of this, the `TulsiGenerator` framework builds a `macos_command_line_application`...

jerrymarino

XCHammer is tested on custom modules. The modulemaps generated in Bazel are somewhat of special case: consider how to handle these.

jerrymarino

Bazel targets aren't created for labels using shorthand notation

4

Currently XCHammer creates Bazel targets by the labels specified in the XCHammer config. Since we do a naive string comparison, it will miss labels that aren't using the full label...

jerrymarino

Unstable output in bazel_build_settings.py

1

There are certain parts like platform architectures that are not stable and causes noise in PR reviews and unnecessary diffs. We should ensure we sort any collection types before rendering...

rahul-malik

Currently we add an empty open/close tag command line options when we have zero options to specify. We should avoid creating this entirely. ``` + + ```

rahul-malik

Here is an example diff of what happens today. ``` ``` If you open the project in Xcode it'll fix this for you but we should be generating the buildable...

rahul-malik

This currently happens at least in bazel_build_settings.py but we should audit the entire project for absolute file paths. This will be a blocker as we start to think about project...

rahul-malik

Ad-hoc *.md not included in generated projects

5

Not sure how this should be handled, but Readmes are not included in the final xcode project for the libraries. They are a useful documentation source and should be visible...

mikezucc

We need this for the Xcode targets to work

rahul-malik

An example message is: (reformatted for readability) ``` :: error: Failed to find an output artifact for target ~/Library/Developer/Xcode/DerivedData/HammerLyft-apdrvgdqsckgxbeluodmnicxohsd/Build/Products/Debug-iphonesimulator/libArchitectureCore-Bazel.a in output map { u'generated_sources': [ [u'bazel-out/ios_x86_64-fastbuild/bin/Modules/ArchitectureCore/ArchitectureCore-Swift.h', u'Modules/ArchitectureCore/ArchitectureCore-Swift.h'], [u'bazel-out/ios_x86_64-fastbuild/bin/Modules/ArchitectureCore/ArchitectureCore.swiftmodule', u'Modules/ArchitectureCore/ArchitectureCore.swiftmodule'], [u'bazel-out/ios_x86_64-fastbuild/bin/Modules/ArchitectureCore/ArchitectureCore.modulemaps/module.modulemap',...

kastiglione