PodToBUILD icon indicating copy to clipboard operation
PodToBUILD copied to clipboard

Add missing features in React 0.61.5

Open jerrymarino opened this issue 4 years ago • 3 comments

I'm hitting a few issues in attempting to build React 0.61.5 with PodToBUILD on the following archive: 'https://github.com/facebook/react-native/archive/v0.61.5.zip'

The following situations are occurring which make this tricky to handle

  • Aliasing doesn't alias all subspecs, only the top level one. This requires manually aliasing right now.
  • Header namespaces are mixed up for a child pod. For example, RCTText and RCTImage.
  • There is a convention of importing pods into the Podfile from a subspec? e.g. pod 'React-Core/DevSupport', :path => "#{prefix}/"

jerrymarino avatar Apr 07 '20 21:04 jerrymarino

There are also examples of where glob patterns are broken due to child build files: e.g.

# Vendor/React/React-Core.podspec
'RCTTextHeaders'              => 'Libraries/Text/**/*.h',

While we currently are sticking a build file at

Vendor/React/Libraries/Text

jerrymarino avatar Apr 07 '20 21:04 jerrymarino

Is 61.4 the latest react native that works in PodToBUILD then?

rockwotj avatar Oct 09 '20 17:10 rockwotj

It looks the version used in the example is 0.63.1, so I'm assuming some of these things were fixed since then? I can't confirm it works fully though, as I can build the example, but I can't figure out how to depend on it. I am trying with the react native template project and cannot find the headers:

ios/HelloWorld/AppDelegate.h:7:9: fatal error: 'React/RCTBridgeDelegate.h' file not found
#import <React/RCTBridgeDelegate.h>

joprice avatar Jan 29 '21 14:01 joprice