toolchains_llvm icon indicating copy to clipboard operation
toolchains_llvm copied to clipboard

refactor: migrate to rules based toolchain

Open thesayyn opened this issue 7 months ago • 4 comments

WIP, https://github.com/bazel-contrib/toolchains_llvm/issues/444

thesayyn avatar May 13 '25 19:05 thesayyn

@thesayyn Sorry, I forgot about this. Is this ready for review?

fmeum avatar Jun 13 '25 15:06 fmeum

@fmeum its not close to being done, but i'd really appreciate the early feedback here. I am committed to land this and some more.

thesayyn avatar Jun 13 '25 20:06 thesayyn

@thesayyn Took me a while not the general approach looks good to me.

I like to see a workaround for bazelbuild/rules_cc#277 - have you tried to upstream it?

This repo currently reuses the toolchain config from rules_cc. Is your plan to no longer do this or to also migrate the default toolchain to the new rules? Either would be fine, just curious.

fmeum avatar Jun 29 '25 06:06 fmeum

Ran into this issue when trying to fix toolchains_llvm to respect rules_sh posfix toolchain to replace #!/bin/bash with the correct path. From my perspective merging this PR will allow me to fix nixos builds.

@thesayyn is this PR stale? Would you mind if I continue the work here?

TroyKomodo avatar Jul 07 '25 02:07 TroyKomodo