toolchains_llvm icon indicating copy to clipboard operation
toolchains_llvm copied to clipboard

Clangs 19+ for AArch64 can't be used because of "LLVM"/"clang+llvm" confusion

Open jwbee opened this issue 10 months ago • 2 comments

PR #461 looks as if it partially addresses this but the function llvm_release_name is still forcing clang 19 archives to be called "LLVM-...tar.xz" even though the archives for linux-aarch64 are named "clang+llvm-...tar.xz"

jwbee avatar Feb 18 '25 18:02 jwbee

I improved on 471 in https://github.com/bazel-contrib/toolchains_llvm/pull/472.

The new PR allows to not only automatically find the latest version it allows to restrict versions.

For instance the following would find any version starting with 19.1.1 but would not allow 19.1.7 (did not work for us) and would not accept any version starting with 20. Effectively allowing any newer version in the 19 branches but skipping 19.1.0 and 19.1.7.

llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm", dev_dependency = True)
llvm.toolchain(
    name = "llvm_toolchain_llvm",
    llvm_version = "latest:>=19.1.1,!=19.1.7,<20",
)
use_repo(llvm, "llvm_toolchain_llvm")

helly25 avatar Mar 15 '25 19:03 helly25

Automatic distribution resolution has been reimplemented in #471 waiting for release.

helly25 avatar May 11 '25 19:05 helly25

anything left to do here?

scasagrande avatar Sep 06 '25 19:09 scasagrande

We need to give it some time to add more distributions. By now there should actually be two more. I'll add then as I get to it.

On Sat, Sep 6, 2025, 21:02 Steven Casagrande @.***> wrote:

scasagrande left a comment (bazel-contrib/toolchains_llvm#464) https://github.com/bazel-contrib/toolchains_llvm/issues/464#issuecomment-3263037505

anything left to do here?

— Reply to this email directly, view it on GitHub https://github.com/bazel-contrib/toolchains_llvm/issues/464#issuecomment-3263037505, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ7NSIBT2B6UDKV6KL62D33RMVTDAVCNFSM6AAAAABXMITIW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENRTGAZTONJQGU . You are receiving this because you commented.Message ID: @.***>

helly25 avatar Sep 06 '25 22:09 helly25

Actually we can close this.

helly25 avatar Sep 08 '25 08:09 helly25