toolchains_llvm icon indicating copy to clipboard operation
toolchains_llvm copied to clipboard

chore(deps): update dependency rules_cc to v0.0.13

Open renovate[bot] opened this issue 1 year ago • 5 comments

This PR contains the following updates:

Package Type Update Change
rules_cc bazel_dep patch 0.0.9 -> 0.0.13
rules_cc http_archive patch 0.0.9 -> 0.0.13

Release Notes

bazelbuild/rules_cc (rules_cc)

v0.0.13

Compare Source

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.13/rules_cc-0.0.13.tar.gz"],
    sha256 = "d9bdd3ec66b6871456ec9c965809f43a0901e692d754885e89293807762d3d80",
    strip_prefix = "rules_cc-0.0.13",
)
What's Changed
New Contributors

Full Changelog: https://github.com/bazelbuild/rules_cc/compare/0.0.12...0.0.13

v0.0.12

Compare Source

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.12/rules_cc-0.0.12.tar.gz"],
    sha256 = "b26168b9a13f094794982b832975eaf53cefc5dced5b3be7df6b8b794dc2744b",
    strip_prefix = "rules_cc-0.0.12",
)

Full Changelog: https://github.com/bazelbuild/rules_cc/compare/0.0.11...0.0.12

v0.0.11

Compare Source

Loading rules_cc
load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.11/rules_cc-0.0.11.tar.gz"],
    sha256 = "7e2a1f6c5dd908e6e88d7c80257c99d14e16fa985b56342287fddb6a32c435b5",
    strip_prefix = "rules_cc-0.0.11",
)
What's Changed
New Contributors

Full Changelog: https://github.com/bazelbuild/rules_cc/compare/0.0.10...0.0.11

v0.0.10

Compare Source

What's Changed

Full Changelog: https://github.com/bazelbuild/rules_cc/compare/0.0.9...0.0.10

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.10/rules_cc-0.0.10.tar.gz"],
    sha256 = "65b67b81c6da378f136cc7e7e14ee08d5b9375973427eceb8c773a4f69fa7e49",
    strip_prefix = "rules_cc-0.0.10",
)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Sep 13 '24 17:09 renovate[bot]

Tests are failing because we (currently) aim to support Bazel 7.0 and rules_cc recently inherited @bazel_tools//cpp:* stuff from Bazel at HEAD:

  • https://github.com/bazelbuild/rules_cc/commit/c2549f6eb07ce00e529b84f9b9f1b31135a9ff77
  • https://github.com/bazelbuild/bazel/commit/1c4e78a9ceab9794140324d64833c628e382a3da

The problematic change for us is cc_configure's use of reproducible on module_ctx.extension_metadata (added here in bazelbuild/bazel#22335) which wasn't added until bazelbuild/bazel#20272 (7.1.0).

I assume we want to update rules_cc to gate the reproducible argument using bazel_features instead of bumping our minimum supported Bazel version?

cc: @fmeum

edit: filed https://github.com/bazelbuild/rules_cc/pull/254

rrbutani avatar Oct 11 '24 21:10 rrbutani

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Oct 11 '24 21:10 renovate[bot]

Looks like we've got another error from rules_cc when not using bzlmod:

ERROR: Skipping '//:all': while parsing '//:all': error loading package '': at /home/runner/.cache/bazel/_bazel_runner/f764bf27ef94a0d5a3cfad3bad3e40be/external/rules_cc/cc/defs.bzl:16:6: Unable to find package for @@protobuf//bazel:cc_proto_library.bzl: The repository '@@protobuf' could not be resolved: Repository '@@protobuf' is not defined.
ERROR: Skipping '//:test_cxx_standard_is_20': error loading package '': at /home/runner/.cache/bazel/_bazel_runner/f764bf27ef94a0d5a3cfad3bad3e40be/external/rules_cc/cc/defs.bzl:16:6: Unable to find package for @@protobuf//bazel:cc_proto_library.bzl: The repository '@@protobuf' could not be resolved: Repository '@@protobuf' is not defined.

rrbutani avatar Oct 11 '24 21:10 rrbutani

I'll look into the rules_cc failures. In WORKSPACE land, it should depend on protobuf via its legacy name com_google_protobuf.

fmeum avatar Oct 12 '24 10:10 fmeum

Sent https://github.com/bazelbuild/rules_cc/pull/255

fmeum avatar Oct 12 '24 11:10 fmeum