bayesrules
bayesrules copied to clipboard
bayes-rules
Check variable types in moma
Some variable types do not seem as appropriate. For instance, artist is labeled as a factor.
We'll have to be careful changing any factors. The book relies on this for plotting and modeling. We'd have to go through and change code if we change the data structure. I vote for keeping it (maybe out of laziness, but also because it would take time to change at this point).
On Sat, Sep 25, 2021 at 4:05 PM Mine Dogucu @.***> wrote:
Some variable types do not seem as appropriate. For instance, artist is labeled as a factor.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bayes-rules/bayesrules/issues/84, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDOVOW46YMKO4JNAPDKSEDUDY2THANCNFSM5EX7VFSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Alicia Johnson she/her Associate Professor Mathematics, Statistics, and Computer Science Macalester College
No worries, I would not change it now. Possibly for the next version when we have the time and energy to make sure nothing breaks. I just noted it. The problem is with read.csv() makes everything it desires a factor. In the future, once we are sure nothing breaks we can change that to read_csv().
I actually would advocate changing this for future versions. Just noting it here. For instance, mutation of birth from factor to numeric actually gives factor level rather than birth year.