add option to provide an option for color fill in some graphs #820

[ElderOrb]

[dericed]

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

[ElderOrb]

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

[dericed]

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

Did you push this commit? Example?

[dericed]

Also in the right area, the plot labels are running out of the ui,

Could we reduce the space between these?

[ElderOrb]

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

Did you push this commit? Example?

yep, https://github.com/bavc/qctools/pull/826/commits/3d1cfd06b7637df49153dfb11819d83972b4fd9c#diff-5af9fe2734d6e69a5899ebbfbbf102bb170b97f59e390fbbf0224be72cb42247R277

[ElderOrb]

Also in the right area, the plot labels are running out of the ui,

Could we reduce the space between these?

like this?

[dericed]

I think reducing the spacing causes some labels to get cut off in the tiles.

[dericed]

The fill is being filled even in yet unplotted areas.

I'm using

    //Diffs
    { Group_VDiff,   Group_Diffs,          "V DIF",         "lavfi.signalstats.VDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkred",    1, "0;darkred;0.4" },
    { Group_UDiff,   Group_Diffs,          "U DIF",         "lavfi.signalstats.UDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkblue",   1, "0;darkblue;0.4" },
    { Group_YDiff,   Group_Diffs,          "Y DIF",         "lavfi.signalstats.YDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkgreen",  1, "0;teal;0.4" },

[dericed]

Can you cherry-pick in https://github.com/bavc/qctools/pull/828/commits/0fc12fa52b0d4b47e67aa95d59aa84442b7a5a77 before any updates?

[dericed]

In testing again and found this:

• in preferences be sure that Tiled Center Row and Tiled Center Column are enabled
• in graph make sure the visibility of Tiled Center Row and Tiled Center Column are disabled
• open a file and let it graph
• then in the graph, enable the visibility of Tiled Center Row and Tiled Center Column. But they won't appear

if you enable the Tiled Center Row and Tiled Center Column visibility before graphing, then they show as expected.

[dericed]

Ah, this is broken in main too, so not a regression of this PR.