Benjamin Valpey

Results 32 comments of Benjamin Valpey

I'm thoroughly happy with the simplicity of secrets. It follows similar frameworks such as Cloudflare workers, except is even easier to work with. Please don't change :(

> The idea is mainly about making it easier to customize the approach, such as using a `.env` file if you want to I think that having multiple ways to...

Since this has now gotten attention from @sumneko I think it's worth pointing out another very similar issue that can potentially be solved by this. That is, similar challenges with...

> [@carlosala](https://github.com/carlosala) It should default to XDG_DATA_HOME/oh-my-zsh then and if it isn't defined fallback to $HOME/.oh-my-zsh Nope, then you're still not following the spec. The spec says if XDG_DATA_HOME isn't...

> Can you write a concrete example of how would you use this? So, I would use this like so: ```rust #[cfg(not(cbindgen)] type FfiStrArray = *const FfiStr #[cfg(cbindgen]) struct FfiStrArray...

`---@type` is definitely compatible with `---@param` ![image](https://github.com/LuaLS/lua-language-server/assets/36710691/94aca0f6-f252-48c6-b5be-9a7615a23831) ![image](https://github.com/LuaLS/lua-language-server/assets/36710691/452f1a7d-8913-458a-9220-613b28a240ab)

Seems like you want the opposite of ``---@nodiscard``? Shouldn't explicitly writing ``nil`` as the return type do that? There's almost 0 runtime difference between `return` and `return nil` To implement...

I've been looking into this more and I think that cbindgen should set ``RUSTC_BOOTSTRAP`` in the command line where it invokes ``rustc``. This is what ``cargo-expand`` does. That way, we...

Cargo-expand is one of the more popular crates. It uses this option, and has for a long time. You also can follow the same logic it uses to determine if...

> Setting RUSTC_BOOTSTRAP from a tool is a big no-no. You're not setting it from the tool permanently. You are setting it only for your invocation of rustc, via the...