capacitor-firebase-auth icon indicating copy to clipboard operation
capacitor-firebase-auth copied to clipboard

Streamlined Provider ID retrieval

Open mauriceackel opened this issue 4 years ago • 3 comments

I realized that provider IDs are sourced differently at different places in the code. The change streamlines the retrieval of provider IDs and now always uses the static PROVIDER_ID property instead of the object property providerId:

Old: new firebase.auth.GoogleAuthProvider().providerId

New: firebase.auth.GoogleAuthProvider.PROVIDER_ID

mauriceackel avatar Apr 27 '21 18:04 mauriceackel

Hi @mauriceackel ,

Can you please change your PR to point to the next branch.

Best regards.

baumblatt avatar Aug 11 '21 12:08 baumblatt

Done, but it seems that I need to resolve some conflicts. I will try to do this later and give you an update

mauriceackel avatar Aug 11 '21 12:08 mauriceackel

@baumblatt The PR is refactored and should be fine now.

Best, Maurice

mauriceackel avatar Aug 11 '21 14:08 mauriceackel