flask-pydantic icon indicating copy to clipboard operation
flask-pydantic copied to clipboard

Improve typing

Open MarekPikula opened this issue 2 years ago • 10 comments

Fixes #65

Typing:

  • make it pass mypy tests (i.e., improve type hinting) – both main module and tests
  • add mypy test to CI
  • add py.typed to setup so that other packages recognize it's typed
  • make it possible to use TypeVars for model hinting

General

  • enable async view function decoration (via ensure_sync() as noted on https://flask.palletsprojects.com/en/latest/async-await/#extensions)
  • set isort profile to black

CI:

  • update GitHub actions to newest revisions
  • Run linters in a separate matrix (black, flak8, mypy)

MarekPikula avatar Apr 18 '23 19:04 MarekPikula

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 18 '23 19:04 sonarqubecloud[bot]

Hi @bauerji, is there any chance to merge this PR?

MarekPikula avatar Jun 03 '23 00:06 MarekPikula

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 04 '23 13:06 sonarqubecloud[bot]

Hi @bauerji, any news regarding this PR? I've made the changes you requested some time ago. Let me know what can I do to move this PR forward.

If you give me a green light for the recent changes, I'll rebase this PR on the main branch.

MarekPikula avatar Jun 15 '24 16:06 MarekPikula