Jonathan Hettwer

Results 42 comments of Jonathan Hettwer

So, after a bit of thinking, I suspect this to be a good old case of user error and unclear documentation. There's nothing per se wrong with the code, but...

Appears to have been caused by https://github.com/rust-lang/cargo/commit/8a7ba8f8d93760f1aeeac9a0b33c641cb177cc31 where the initial `rustc -vV` invocation is now also passed through the wrapper specified by cargo-call-stack. I made a very rough fix on...

I've fixed all the linting errors and changed `object` to `str` instead.

Changes for `apt-get upgrade` are untested, but you get the idea.

@Fizzadar The operations unit tests `FakeHost.get_fact` does not actually support positional arguments, how can I fix that ?

So, I've "fixed" the test, but this also kind of breaks existing tests, since the facts kwarg string is now different. Actually, it doesn't even break all tests, e.g. https://github.com/pyinfra-dev/pyinfra/pull/1179/commits/c884c43370c015d17bd5fb0ed70c13dabc427550...

Right, I forgot about that, now I have the following: ```python def systemd_unit_enabled_state(unit: str) -> str | None: enabled_state = host.get_fact(Command, command=f"systemctl is-enabled {unit} || true") return enabled_state @operation() def...

> Not OP, but I've run into this issue as well, but unfortunately haven't figured out how to reliably reproduce the issue. Typically it presents where the song appears to...

I already implemented that in https://github.com/docker/docker-py/pull/3230

I think the logic of `ostree admin set-origin` needs some other improvements, or generalizations. Or maybe only the man page needs to be updated. I've deployed a specific commit, and...