Bastian Schmidt

Results 244 comments of Bastian Schmidt
trafficstars

> Have you thought about how it can be tested? How did you confirm the performance is improved? I asked about how we are expected to write tests in multiple...

@harshit7962 Will have a look as soon as i can.

Created PR #9393 to fix the issues

@harshit7962 The first error i encounter is an exception because a `SolidColorBrush` is being used as a `Color` inside of `ButtonStyles.xaml` in line 2 where it says ``. This was...

Just adding my opinion for the changes to `Button`, `TextBox` and `DataGrid` as of yet. Button: We already have styles, i don't see any reason to add an `Appearance` property....

@dipeshmsft > As of now, we have removed the properties from DataGrid, but can you provide/point to a code which showcases this. Different CheckBox-Columns might: - have different bindings for...

@dipeshmsft Please don't use the A11y argument to force a specific implementation on users of WPF. Don't get me wrong. A11y is important and should always be considered. But removing...

That looks better. When does the placeholder become visible? I am asking because currently it looks like it's always visible when there is no input. In my application the placeholder...

@miloush Indeed. The code for placeholder and clear is extremely problematic. Changes like setting the caret position on focus are concerning too. @dipeshmsft Can you clarify why placeholder and clear...

@dipeshmsft > If I am not wrong, the gist is that with the current implementation you will lose the customization for when to hide the placeholder. I wouldn't loose the...