Ecmascript-Sublime icon indicating copy to clipboard operation
Ecmascript-Sublime copied to clipboard

Add support for graphql nested syntax

Open Janpot opened this issue 6 years ago • 5 comments

As title says 🙂 I'd say graphql tagged templates are quite common in javascript code

Janpot avatar Sep 19 '18 09:09 Janpot

Sure! The problem though is that as of now there only seems to be one GraphQL syntax and the scopes that it creates look terrible in our color schemes, we actually have this problem with a few other syntaxes but this one in particular is really ugly: screen shot 2018-09-19 at 8 11 38 am

I would suggest we'd first need to make a bit of effort to add each scope to (at least) one of the color schemes (likely excelsior since this is the one that supports nested syntaxes right now).

blake-regalia avatar Sep 19 '18 15:09 blake-regalia

@blake-regalia I also just realised I often use lua in javascript for scripting with redis. Do you think that would be valuable target as well for nested syntax?

Janpot avatar Sep 20 '18 06:09 Janpot

@Janpot absolutely. Lua syntax comes with ST3 and their scopes tend to look more natural in the color scheme so that should be no problem.

blake-regalia avatar Sep 20 '18 16:09 blake-regalia

@Janpot v1.8.0

blake-regalia avatar Sep 23 '18 19:09 blake-regalia

Should also add highlighting support for template tag gql from https://github.com/apollographql/graphql-tag

blake-regalia avatar Jan 01 '20 22:01 blake-regalia