pybatfish icon indicating copy to clipboard operation
pybatfish copied to clipboard

Add proxies and timeout parameters

Open cprevot93 opened this issue 3 months ago • 4 comments

Relay on requests features.

Proxies Timeout

Timeout is important because: "By default, requests do not time out unless a timeout value is set explicitly. Without a timeout, your code may hang for minutes or more."

This change does not affect current codebase, except that it sets the connection timeout to 30 seconds. I doubt it will cause any code to break.

cprevot93 avatar Nov 05 '25 11:11 cprevot93

This change is Reviewable

batfish-bot avatar Nov 05 '25 11:11 batfish-bot

Rad, but CI didn't pass. Can you fix it?

dhalperi avatar Nov 07 '25 02:11 dhalperi

Sorry, I'm having a hard time to run the test with uv. I still haven't test it, but hopefully it should be good now.

cprevot93 avatar Nov 12 '25 19:11 cprevot93

Tests are green ,left 2 Qs for you. Feel free to ping me on Batfish slack.

I got to these Qs because I was trying to write the release notes and realied I couldn't figure out how to undo the breaking change.

dhalperi avatar Nov 12 '25 20:11 dhalperi