pybatfish icon indicating copy to clipboard operation
pybatfish copied to clipboard

Published 20 hours ago • verified publisher icon batfish

Fix RFC1918 space

Open Antonio-Prado opened this issue 2 years ago • 1 comments

172.16.0.0/12

Antonio-Prado avatar Oct 14 '22 10:10 Antonio-Prado

This change is Reviewable

batfish-bot avatar Oct 14 '22 10:10 batfish-bot

Thanks!

are you going to commit?

Antonio-Prado avatar Oct 18 '22 09:10 Antonio-Prado

Tests aren't passing

On Tue, Oct 18, 2022 at 02:50 Antonio Prado @.***> wrote:

Thanks!

are you going to commit?

— Reply to this email directly, view it on GitHub https://github.com/batfish/pybatfish/pull/861#issuecomment-1282127374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAQT26JPSMN42CHS5HBWTWDZXHLANCNFSM6AAAAAARFDK7J4 . You are receiving this because you commented.Message ID: @.***>

dhalperi avatar Oct 18 '22 11:10 dhalperi

Tests aren't passing

I see, is there anything else I can do with the tests?

Antonio-Prado avatar Oct 18 '22 16:10 Antonio-Prado

Hi @Antonio-Prado - yes, please re-generate the notebooks so that the tests pass.

dhalperi avatar Oct 27 '22 18:10 dhalperi

Hi @Antonio-Prado - yes, please re-generate the notebooks so that the tests pass.

hi, how can I re-generate the notebooks? thank you

Antonio-Prado avatar Nov 03 '22 16:11 Antonio-Prado

Hi @Antonio-Prado - I had to fix the router configs to update the PLs to match the corrected RFC definition. If this passes, I will merge.

dhalperi avatar Dec 08 '22 17:12 dhalperi