batfish icon indicating copy to clipboard operation
batfish copied to clipboard

CompareSameName: stop using JSONAssert

Open dhalperi opened this issue 1 year ago • 2 comments

They have released some breaking changes, and it's only used here. Do we need it?

dhalperi avatar Jun 24 '24 15:06 dhalperi

This change is Reviewable

batfish-bot avatar Jun 24 '24 15:06 batfish-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.64%. Comparing base (67b862f) to head (eb0d7b7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9084      +/-   ##
==========================================
- Coverage   72.64%   72.64%   -0.01%     
==========================================
  Files        3316     3316              
  Lines      169708   169703       -5     
  Branches    19952    19952              
==========================================
- Hits       123280   123274       -6     
+ Misses      37253    37252       -1     
- Partials     9175     9177       +2     
Files Coverage Δ
...del/collections/NamedStructureEquivalenceSets.java 70.27% <100.00%> (+3.18%) :arrow_up:

... and 5 files with indirect coverage changes

codecov[bot] avatar Jun 24 '24 15:06 codecov[bot]