Alex
Alex
> I might work on it sometime today :shipit:
Agreed with @ethteck. The way this PR is currently written requires that there only be one CodeMirror on the page at once, which is the case today, but might not...
See also #115
Also sounds very similar to #128
Do you think the owner of the scratch only should be able to mark points on the target asm? Should they persist across all instances of the target asm or...
> we were thinking of this initially as a frontend-only feature. but we could add backend stuff to it, just not sure how necessary it is I think this feature...
> I think ideally though you'd be able to set "notable points" without needing to name them, since I think that could disrupt the flow a bit as you're decompiling....
> either way, can't we save the bookmarks with local browser storage? This makes sense, we could do it this way for now to skip the backend
IMO: 1. https://github.com/decompme/decomp.me/issues/361 2. Read `.clang-format`
We use a [#line directive](https://learn.microsoft.com/en-us/cpp/preprocessor/hash-line-directive-c-cpp?view=msvc-170) to tell the compiler when `code.c` begins: https://github.com/decompme/decomp.me/blob/576b0006f40a2a5d4fda9e8d5465c5faaf2c9f04/backend/coreapp/compiler_wrapper.py#L148-L154 This is likely a bug in your compiler - does it support #line?