Jacob Turner

Results 20 comments of Jacob Turner

https://github.com/anoma/namada/blob/4bc441e938eb7be84824deacb12d79e07c780de4/apps/src/lib/node/ledger/shell/mod.rs#L573

If you chase that function down, it leads here: https://github.com/anoma/namada/blob/4bc441e938eb7be84824deacb12d79e07c780de4/core/src/ledger/storage/merkle_tree.rs#L395

Oh wow, haven't thought about this in a while. I'll need to dig back into it

Yes, this is still relevant @cwgoes

> let's rm the cli arg and always validate Sorry for not getting to this sooner. Fixing now.

> What's the status of this? Still relevant? @batconjurer Very much. I though that this was already merged actually

@brentstone This has been updated and should be ready to go.

Given that this parameter might be changed in namada storage by a fork, I think the best way to handle this is to take the minimum of the tx byte...

> hmmm I just realized why we started using `max_proposal_bytes` in the first place. `ProcessProposal` doesn't include `max_tx_bytes`, so it's impossible to validate the value the validator was using Yep,...

> @batconjurer Is this PR rdy for draft? Yes it is