BAT.jl icon indicating copy to clipboard operation
BAT.jl copied to clipboard

WIP MCMC with transforms Interface

Open waldie11 opened this issue 2 years ago • 6 comments

FYI @oschulz @Cornelius-G

waldie11 avatar Jun 30 '23 12:06 waldie11

Can you check the

Base.Meta.ParseError("parsing error in src/samplers/transformed_mcmc/struct_list.jl:34: missing comma or } in argument list")

CI error on Julia 1?

oschulz avatar Jun 30 '23 20:06 oschulz

Codecov Report

Patch coverage has no change and project coverage change: -5.76% :warning:

Comparison is base (78e9339) 55.06% compared to head (9cb2625) 49.31%.

:exclamation: Current head 9cb2625 differs from pull request most recent head b6565c3. Consider uploading reports for the commit b6565c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   55.06%   49.31%   -5.76%     
==========================================
  Files         116      131      +15     
  Lines        5619     6323     +704     
==========================================
+ Hits         3094     3118      +24     
- Misses       2525     3205     +680     
Files Changed Coverage Δ
src/BAT.jl 100.00% <ø> (ø)
src/samplers/transformed_mcmc/chain_pool_init.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_algorithm.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_convergence.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_iterate.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_sample.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_sampleid.jl 0.00% <0.00%> (ø)
src/samplers/transformed_mcmc/mcmc_stats.jl 0.00% <0.00%> (ø)
...rs/transformed_mcmc/mcmc_tuning/mcmc_noop_tuner.jl 0.00% <0.00%> (ø)
...sformed_mcmc/mcmc_tuning/mcmc_proposalcov_tuner.jl 0.00% <0.00%> (ø)
... and 7 more

... and 64 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 03 '23 13:07 codecov[bot]

I've updated this to use the new BATContext. "transformed_example.jl" doesn't fully run through, but I'm not sure if that's related.

oschulz avatar Jul 06 '23 08:07 oschulz

TransformedAdaptiveMHTuning in the example works now, but

r_hmc = @time BAT.bat_sample_impl(posterior, MCMCSampling(mcalg=HamiltonianMC(), nchains=4, nsteps=4*20000), context)

in the example doesn't work yet, but that's to be expected currently, right?

I think BATContext-wise this is fine now.

oschulz avatar Jul 06 '23 08:07 oschulz

TransformedAdaptiveMHTuning in the example works now, but

r_hmc = @time BAT.bat_sample_impl(posterior, MCMCSampling(mcalg=HamiltonianMC(), nchains=4, nsteps=4*20000), context)

in the example doesn't work yet, but that's to be expected currently, right?

Hm, for me this line works. As it should, because that is just the "good old" HMC smapling, not using the new transformations.

Cornelius-G avatar Jul 06 '23 08:07 Cornelius-G

Ah - well, in any case, I think the adaption to BATContext is complete.

oschulz avatar Jul 06 '23 09:07 oschulz

@Micki-D needs to be updated to API changes.

oschulz avatar May 21 '24 13:05 oschulz

Closing in favor of #441

oschulz avatar Jun 05 '24 13:06 oschulz