osaka
osaka copied to clipboard
basvodde
Replace calls to "Don't Save" button to "Delete" as Mountain Lion uses the latter
Specs fail in Mountain Lion as the "Don't Save" button is now "Delete". I would think this was caused by deeper iCloud integration in apps such as TextEdit. Specs in question should now pass in Mountain Lion.
I would think that this fix is not complete, as this should break things in Lion and earlier. Unfortunately I do not have an environment to confirm. May need to add a more intelligent check to call the correct button based on the OS.
Yeah, this can't work :) It would break it on other versions. That said, I have mountain lion and haven't gotten this test failure before, so I'm a bit puzzled about it...
That's interesting. Do you have iCloud configured on your Mountain Lion perhaps?
On Apr 15, 2013, at 9:41 AM, Bas Vodde [email protected] wrote:
Yeah, this can't work :) It would break it on other versions. That said, I have mountain lion and haven't gotten this test failure before, so I'm a bit puzzled about it...
— Reply to this email directly or view it on GitHub.
Nope, I don't have iCloud configured. Do you?
Bas
On 15 Apr, 2013, at 11:37 AM, Ealden Escanan [email protected] wrote:
That's interesting. Do you have iCloud configured on your Mountain Lion perhaps?
On Apr 15, 2013, at 9:41 AM, Bas Vodde [email protected] wrote:
Yeah, this can't work :) It would break it on other versions. That said, I have mountain lion and haven't gotten this test failure before, so I'm a bit puzzled about it...
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub.
Yes. I'm not sure how it would look like if iCloud was not set, but this is what I see:
The delete button I mentioned is this:
Ok, then it would probably be better to change the code to check if the "Don't Save" button exists, and if it doesn't exist then hit the Delete button. That should work also on non iCloud.
Wow, someone uses iCloud :P