agnostik icon indicating copy to clipboard operation
agnostik copied to clipboard

Support no_std executors

Open Stupremee opened this issue 5 years ago • 7 comments

Since async / await is available in no_std environment now, agnostik should add a no_std runtime.

I'm not sure if it should implement an own no_std executor or using an already existing crate.

Stupremee avatar Mar 23 '20 23:03 Stupremee

I have one written here if it helps at all.

https://github.com/richardanaya/executor

I'm pretty interested in collaborating. I had a similar idea in my own package, but i'd be willing to conform to Agnostik's interface if its possible.

richardanaya avatar Mar 24 '20 19:03 richardanaya

Hi @richardanaya ! Great news, I would be very happy to incorporate your executor. The first thing comes into my mind is using your executor as defacto no_std executor. Is it ok at your end? Feel free to open a PR if that suits to you :)

vertexclique avatar Mar 24 '20 19:03 vertexclique

Absolutely!

richardanaya avatar Mar 24 '20 19:03 richardanaya

if you want you can open a PR and implement your executor. You just have to uncomment the runtime_nostd in Cargo.toml and ci.sh and remove the core dependency.

Stupremee avatar Mar 24 '20 20:03 Stupremee

Thanks! I tried integrating it this afternoon, I found some changes i need to make to my library to be more compliant.

On Tue, Mar 24, 2020 at 1:21 PM stu [email protected] wrote:

if you want you can open a PR and implement your executor. You just have to uncomment the runtime_nostd in Cargo.toml and ci.sh and remove the core dependency.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bastion-rs/agnostik/issues/3#issuecomment-603484396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHZGSXMNZWHDEZNQN5JMTRJEI5TANCNFSM4LSHQR6Q .

richardanaya avatar Mar 24 '20 21:03 richardanaya

https://github.com/bastion-rs/agnostik/pull/7

richardanaya avatar Mar 25 '20 13:03 richardanaya

FYI, i'm no longer working on this as per #7. Someone else is free to take over.

richardanaya avatar Apr 07 '20 17:04 richardanaya