homer
homer copied to clipboard
bastienwirtz
Fix Immich fetch stats
api changes in immich v1.85.0
Description
In Immich v1.85.0 the "/server-info/stats" endpoint was changed to "/server-info/statistics" per the release notes https://github.com/immich-app/immich/releases/tag/v1.85.0
Fixes #719
Type of change
- [ x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
- [x ] I've read & comply with the contributing guidelines
- [ x] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
- [ x] I have made corresponding changes to the documentation (README.md).
- [x ] I've checked my modifications for any breaking changes, especially in the
config.ymlfile
Deploy Preview for homer-demo-content ready!
| Name | Link |
|---|---|
| Latest commit | 2335328e4239765b02339c1b0d172978679f2f73 |
| Latest deploy log | https://app.netlify.com/sites/homer-demo-content/deploys/654fe68178efea00087d71ab |
| Deploy Preview | https://deploy-preview-722--homer-demo-content.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for submitting a PR to utilize the new API endpoint URL. It appears that this PR simply updates the URL and does not dynamically use the URL corresponding to Immich's version number.
As is, I would suggest also updating documentation customservices.md that Immich version 1.85 is required for the service to function.
I updated the documentation customservices.md to include the required version as recommend that was a good catch. Immich recommends updating to the newest version as soon as possible anyways so I personally don't think its completely necessary to make the logic too complicated for version detection. That being said this is more of a quick fix and the api is bound to change as the service gets updated.
Merging is still blocked, because a review is required, even though there is an approving review by @w00tlarr?
@bastienwirtz - anyway to merge this? The URI is a straightforward change to the new Immich URI. Thanks!
Thanks for your patience! it looks good, thanks for your contribution!
