homer icon indicating copy to clipboard operation
homer copied to clipboard

Feature request: dashy’s icon fetcher

Open mybuntu-git2 opened this issue 1 year ago • 2 comments

Hi, I just moved to Homer from Dashy and want to suggest to use dashy’s icon finder code: basically dashy finds the icon of the item for the user, and/or searches it. having some clunky cli command that tires to fetch icons for config.yml items and/or via user input, could be a huge timesaver and improve ux without affecting performance (runs once if the modification date of config file is more recent than icons, and runs only for icons for which it finds no corresponding file).

by the way, very nice app and impressively lightweight!

mybuntu-git2 avatar Aug 26 '22 19:08 mybuntu-git2

Hi @mybuntu-git2 ! Thanks for the feedback :)

Are you talking about the icon: favicon feature ? or the fetch from API like allesedv.com or Icon.Horse ?

bastienwirtz avatar Aug 27 '22 09:08 bastienwirtz

Hi, It was the api fetch yes

mybuntu-git2 avatar Aug 27 '22 10:08 mybuntu-git2

Hi,

Didn't know these services, they are great! :)

Not sure, but I think this covers edge cases:

  • No logo field --> show no icon. Stays the same.
  • Custom urls in logo fields --> show linked icon. Stays the same.
  • Values allesedv.comor icon.horse in the logo field --> parse url field to get the domain and build the favicon url with it.

what do you think?

luixal avatar Oct 11 '22 11:10 luixal

Hi, Not a fan of urls in config, prefer files due to speed and lack of dependencies. I worked some edge cases with Logo links. Still, would be nice to cannibalize dashy code to have a standalone tool that fetches the icons required for first config.

mybuntu-git2 avatar Oct 13 '22 17:10 mybuntu-git2