homer icon indicating copy to clipboard operation
homer copied to clipboard

Third state in healthchecks and ping: maintenance mode?

Open git-noise opened this issue 2 years ago • 2 comments

Hello,

Many thanks for this great project!

Would it make sense to account for a third state beside online/offline for health checks? Like adding some maintenance flag on the health check service or ping mechanisms? Either via a flag in the config or by reading a specific HTTP code (maybe 503 with seems to be the one mostly used).

Best,

git-noise avatar Nov 08 '21 17:11 git-noise

Hey @git-noise,

Thanks! Regarding internal healthchecks, I don't really think it's necessary as Homer is pure static file and does not require long maintenance operation. Regarding the ping services (used to check if a website or webapp is online) It's a good idea to make it give feedback based the returned http code. I'm adding that to my todo list!

bastienwirtz avatar Nov 14 '21 21:11 bastienwirtz

Hello @bastienwirtz,

Many thanks for your feedback, yes indeed, I may have not expressed my self too clearly, I was thinking of "external health checks" associated to other website/webapps only, not Homer itself. Thanks for taking this feature into account.

Best,

git-noise avatar Nov 15 '21 14:11 git-noise