homer icon indicating copy to clipboard operation
homer copied to clipboard

Speedtesttracker integration

Open boerniee opened this issue 3 years ago • 1 comments

Description

Added a service for the SpeedtestTracker project.

Fixes # (issue)

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [X] I've read & comply with the contributing guidelines
  • [X] I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • [X] I have made corresponding changes the documentation (README.md).
  • [X] I've checked my modifications for any breaking changes, especially in the config.yml file

boerniee avatar Aug 26 '21 18:08 boerniee

Hello!~

What additional work is required for this to be merged? interested in getting this closer to the PR being accepted :)

PedroC1999 avatar Apr 12 '22 11:04 PedroC1999

Hey there, Sorry for letting you wait so long ! I'm will merge this in a new branch to update it before merging it. Thank for your contribution !

bastienwirtz avatar Nov 05 '22 14:11 bastienwirtz

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- OpenWeatherMap Token 41b007f148a278df4fa9180b2be47a05aa48ff88 docs/customservices.md View secret
- OpenWeatherMap Token 41b007f148a278df4fa9180b2be47a05aa48ff88 docs/customservices.md View secret
- OpenWeatherMap Token 41b007f148a278df4fa9180b2be47a05aa48ff88 docs/customservices.md View secret
- OpenWeatherMap Token 41b007f148a278df4fa9180b2be47a05aa48ff88 docs/customservices.md View secret
- OpenWeatherMap Token 41b007f148a278df4fa9180b2be47a05aa48ff88 docs/customservices.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Nov 05 '22 14:11 gitguardian[bot]

There you go: https://github.com/bastienwirtz/homer/blob/main/src/components/services/SpeedtestTracker.vue This is merged on main :+1:

bastienwirtz avatar Nov 05 '22 21:11 bastienwirtz