org-journal icon indicating copy to clipboard operation
org-journal copied to clipboard

Remove key definition in the package loading.

Open sstepashka opened this issue 3 years ago • 3 comments

Avoid modification of Emacs behavior on the package loading.

In order to follow the coding convention, disable key definition in the package loading

sstepashka avatar Apr 25 '21 21:04 sstepashka

Hey @sstepashka! Good point. We should however also update the README.org file which mentions it in several places that org-journal-new-entry can be called with the key C-c C-j.

casch-at avatar Apr 26 '21 10:04 casch-at

Hey @cslux! I updated the document and added "C-c C-j" in org-journal-mode. It was mentioned in the documentation, but seems like it wasn't defined in there.

sstepashka avatar Apr 29 '21 22:04 sstepashka

As this is a breaking change, it should probably get a (temporary) mention near the top of the README.

Otherwise, looks good to me!

bastibe avatar May 05 '21 08:05 bastibe