WebGL-Spectrogram icon indicating copy to clipboard operation
WebGL-Spectrogram copied to clipboard

Allow multiple canvases?

Open joshblum opened this issue 9 years ago • 2 comments

Would you even need/want multiple canvases for audio analysis? I wrapped the spectrogram logic into an object to remove the global use of the gl context to allow for multiple canvases. If you think it would be useful I can submit a PR from https://github.com/joshblum/eeg-spectrogram/tree/multiple-canvases (after removing the EEG logic etc). Let me know what you think :)

joshblum avatar Mar 02 '15 14:03 joshblum

That's pretty cool! I don't think that it is good fit for the original purpose of this project, as this is supposed to be a minimal proof-of-concept for a WebGL spectrogram.

That said, I'd be happy to link to your project in the readme, for a more in-depth application of the same code.

Also, I like the way you refactored the code into a class. I might rewrite the project in ECMAScript 6 with the new class syntax at some point in the future. I'll definitely have a longer look at what you did then.

bastibe avatar Mar 02 '15 15:03 bastibe

Cool :) The code is still a bit janky so I'll submit a PR when it is more stable.

joshblum avatar Mar 02 '15 15:03 joshblum