Tim Meusel

Results 521 comments of Tim Meusel
trafficstars

Sadly, it cannot be merged. This branch has merge conflicts. You can checkout the branch, resolve the conflicts and submit it as a new PR. I'm happy to review and...

I would like to support running hdm without a docker container. I've the code ready, just need to fix up the acceptance tests. Or do we only want to support...

Related issues: * https://github.com/puppetlabs/puppet-editor-services/issues/43 * https://github.com/puppetlabs/puppet-editor-services/issues/208 Looks like puppet-lint is loaded as a lib in a few places: https://github.com/puppetlabs/puppet-editor-services/blob/926c2e074f38d2f0b78ad32bf131b7c1f7862b8d/lib/puppet-languageserver/manifest/validation_provider.rb#L17-L39 https://github.com/puppetlabs/puppet-editor-services/blob/926c2e074f38d2f0b78ad32bf131b7c1f7862b8d/lib/puppet-languageserver/manifest/format_on_type_provider.rb#L25 which makes it real hard to switch to an external...

Given that puppet-lint is not vendored as gem and use siteloaded by modifying the Ruby LOAD path, it should be easy to deploy gems next to it and load them...

@alexjfisher correct, it only helps if the parameters are identical. But it should still help alot.

@alexjfisher updated it, should be much cleaner now :)

It would be nice if one could finally review this :)

@tphoney I offer to fix those CI issues if you merge the PRs and do a 1.0.0 release afterwards :)

Hi @scarybot, thanks for the PR. Can you please rebase this against master? Please also check the used email address in the commit, it isn't associated with your github account.

Hi @scarybot, the email address in the new commit isn't correct :)