Tim Meusel
Tim Meusel
Keep in mind that the legacy facts are legacy since Puppet 5 or 6 and since that time the new ones are available. Just puppet 8 finally disables the legacy...
> I don't think anyone actually deprecated them We (Vox Pupuli) did that a long time ago and so does the pdk since some time.
We made the 2.0.0 release that announced the legacy fact deprecation. I think we can now tackle this and work on the 3.0.0 release which removes the lagacy facts.
@smortex do you have a chance to rebase/redo this PR? I would like to then merge it.
yes, that's why I'm unsure as well. I did say that usual linux boxes at least have a link local address so it would be nice to rely on that...
We've https://github.com/voxpupuli/voxpupuli-rubocop/ which provides a rubocop config for our gems. For Puppet we've to support ancient Ruby versions that are often EoL. We don't have that requirements for most gems...
@DeltaRazero we need to rebase this to merge it. If you're interested you can checkout the branch, rebase against our master and submit it as new PR.
@ekohl metadata-json-lint uses json-schema `'>= 2.8', '< 4.0'`. The next major release will be 4.0 so metadata-json-lint would not automatically pull it in. I suggest we bump Ruby here and...
We now removed Ruby 2.6 and older in another PR. This one just updates rubocop. I left a bit of stuff in the todo file, otherwise the PR would have...
Hi @ronildosouzafb , thanks for raising the issue. Are you able provide a PR for this? On which version of json-schema did you see this?