Tim Meusel

Hi, This got already fixed in our modulesync_config repo: https://github.com/voxpupuli/modulesync_config/pull/535 We just have to roll it out to our modules.

This basically adds RedHat 8 support, right? If so, can you please add CentOS 8 / RedHat 8 to the metadata.json? This depends on https://github.com/camptocamp/facterdb/pull/137

Hi @hbog. Could you add an acceptance test so we know for sure that the generated config works?

Sadly we don't have a license available and I don't have a contact to nginx. Can you add support for the ` nginx-sticky-module-ng` as well? Please update the README.md accordingly.

Ping @hbog :)

I really don't like the configuration of the bot

hi @NITEMAN, thanks for the awesome work. The type/provider, puppet and test code look all pretty solid. I made some tiny inline comments but overall this looke quite good.

thanks! looks good to me now. I added a few reviewers that have more knowledge about elasticsearch/ruby.

Hey @jameskirsop. Are you able to provide a PR with a potential fix or one that provides an acceptance test that fails? So we can narrow down the issue.

That looks okay, can you provide it as a PR? Please don't add `::` leading for variables and use the facts hash facts instead of topscope variables.