homeassistant-generic-hygrostat icon indicating copy to clipboard operation
homeassistant-generic-hygrostat copied to clipboard

A different generic_hygrostat getting merged into HA core

Open ltjessem opened this issue 4 years ago • 8 comments

Looks like generic_hygrostat (not this one, a less functional one) is getting merged into HA core soon. https://github.com/home-assistant/core/pull/36759

Do we need to change the name of the integration in preparation for this?

ltjessem avatar Feb 03 '21 12:02 ltjessem

It seems the other generic hygrostat is more of a humidifier controller with fixed setpoints. I use this integration to compensate for humidity surges when showering by increasing ventilation.

If the other one is merged I don’t see why this shouldn’t be also and a name change might make it easier to convince the bosses.

I believe the reason for merge rejection last time was “you can do this with an automation”, but with the focus now being ease of use and GUI setup I think we should have another go at it. I researched how to set up this integrations functionality with automations and I never got it working

Knodd avatar Feb 03 '21 13:02 Knodd

How about changing name to “humidity controlled ventilation” or something similar?

Knodd avatar Feb 03 '21 13:02 Knodd

IMO since you need to manually create an automation, a better name is "humidity_swing_sensor".

KTibow avatar Feb 03 '21 14:02 KTibow

I agree. This integration should (from a user experience point of view) have an optional setting for a switch entity to turn on /off included and if you want it to do something else an automation could be used. Might have to try to do a PR when I have some time

Knodd avatar Feb 04 '21 14:02 Knodd

Maybe I am stirring up an old discussion, but today I finally switched from a manual installed custom component of this hygrostat to a HACS managed version (so it will be easier to install updates etc.). I put some effort into evaluating the various options, including the hygrostat that is part of the HA core. I came to the conclusion this one (the HACS variant) is better because of the dynamic/adapting limits in comparison to the static limits of the HA core variant. Am I right? And if so, why is the better option not integrated into the HA core?

bartve66 avatar May 22 '22 19:05 bartve66

You are correct. The HA variant is pretty useless as humidity is such a variable thing throughout the year, varying weather conditions etc., you would need to be adjusting the setpoint relatively often. As for getting integrated into HA core, from what I've heard that's a difficult needle to thread. In some cases the HA devs will allow the most ridiculous and useless (breaking) changes, and in other cases actual useful stuff like this is denied for arbitrary reasons. "You can do this with an automation", then they add the most simplistic implementation themselves, that can be done with the most basic of automations. Go figure.

ltjessem avatar May 22 '22 19:05 ltjessem

I also agree that this integration is much better, but it probably does need to be renamed now, since the name conflicts with the one in HA.

ndbroadbent avatar Oct 11 '22 22:10 ndbroadbent

Yup, this need to be renamed. We already have had conflicts reported with confused users.

elupus avatar Jun 27 '24 11:06 elupus