pylon-ros-camera icon indicating copy to clipboard operation
pylon-ros-camera copied to clipboard

Small fixes

Open galou opened this issue 1 year ago • 2 comments

In the process of implementing support for emulated cameras (to come after this PR), I did a few changes to the code (I hope all improvements).

galou avatar Apr 29 '24 06:04 galou

Hello @galou

Thank you for your contributions !

I see that you are pushing changes on this branch once in a while. As long as you're not finished with the work, I won't be able to integrate the changes. So please let me know when you're finished here and do not forget to merge the current master branch within your branch as well. On another note, lots of your changes are purely cosmetics here. I will have a look but may not integrate everything. The cosmetics aspects of a code can be very subjective, generally speaking, and I will stick to the current code conventions and style of the driver.

FrancoisPicardDTI avatar May 27 '24 07:05 FrancoisPicardDTI

I'm finished with my changes, you can integrate them. I'll make further changes to a new branch if I happen to make any.

I tried to isolate the changes so that you can pick the commits individually. I hope that will be possible for you to integrate only part of these changes.

About the cosmetic changes. I tried to respect the coding style of the codebase (except from the trailing whitespaces maybe) and only make some changes to make the code more consistent and not according to my liking.

galou avatar May 27 '24 10:05 galou

Hello @galou I finally took the time to look thoroughly at all your contributions. Many thanks for them! I has indeed greatly improved the code. I included a large majority of your changes in the main/Humble branch now. Thanks again for that and have a nice day!

FrancoisPicardDTI avatar Jul 22 '24 13:07 FrancoisPicardDTI