linearmodels icon indicating copy to clipboard operation
linearmodels copied to clipboard

Effects option does not take effects for predict method?

Open FeiYao-Edinburgh opened this issue 4 years ago • 6 comments

Hi there,

I am using linearmodels to modelling panel data. I just found that the predict method returned me exactly identical results whether I set effects option True or False. They are identical to fitted_values, too, if predictions were made on model data. I believe they are all predictions made by slope and common constant only? Below I provide my codes and relevant outputs for you to check. If no difference, then I do not comprehend the significance of effects option. Or does this option has some other meanings that I do not know?

  • Codes
from linearmodels.datasets import wage_panel
import pandas as pd
data = wage_panel.load()
data = data.set_index(["nr", "year"])

from linearmodels.panel import PanelOLS
exog_vars = ["expersq", "union", "married"]
exog = sm.add_constant(data[exog_vars])
mod = PanelOLS(data.lwage, exog, entity_effects=True)
fe_res = mod.fit()

fe_res.predict(exog.head(), effects = False)
fe_res.predict(exog.head(), effects = True)
fe_res.fitted_values.head()
  • Outputs image

Thanks in advance!

FeiYao-Edinburgh avatar Mar 26 '20 14:03 FeiYao-Edinburgh

Effects are errors and so are not part of the prediction. They are not consistently estimated in the classic fixed T, large N setting. If one dimension is fixed and the other is large, so that the fixed dimension can be consistently estimated, then include these are dummy variables (e.g., time dummies in a large N setting.

bashtage avatar Mar 26 '20 15:03 bashtage

But yes, this seems suspicion.

bashtage avatar Mar 26 '20 15:03 bashtage

Effects are errors and so are not part of the prediction.

Thanks for your clarification!

FeiYao-Edinburgh avatar Mar 26 '20 15:03 FeiYao-Edinburgh

I need to check what this is supposed to do; at a minimum the docstring is inadequate.

bashtage avatar Mar 26 '20 15:03 bashtage

Thanks for the report!

bashtage avatar Mar 26 '20 15:03 bashtage

And the reproducible example.

bashtage avatar Mar 26 '20 15:03 bashtage