Ben Ashbaugh

Results 247 comments of Ben Ashbaugh

We observed in the teleconference on October 17th that there could be a similar issue with buffer and image memory objects, also. Specifically, when is the map count updated, and...

I made a quick tester to try this out: https://github.com/bashbaug/SimpleOpenCLSamples/compare/map-unmap-tester Results were pretty similar across all of the implementations I've tried, though there were a few minor differences. I agree...

Consider separating into multiple issues: * Do we want to return an error from `clEnqueueSVMUnmap` for an arbitrary pointer? * Do we want to return an error from `clEnqueueSVMUnamp` if...

This is a tricky issue! I created #1075 for discussion. Maybe we can decide what we want to clarify first, then we can figure out what we need to change...

FWIW, we currently implement `dot` with pure fp16: https://github.com/intel/intel-graphics-compiler/blob/master/IGC/BiFModule/Implementation/Geometric/dot.cl#L69 We implement `cross` though by upconverting to fp32 - not sure why: https://github.com/intel/intel-graphics-compiler/blob/master/IGC/BiFModule/Implementation/Geometric/cross.cl#L53 I agree it would be nice to implement...

I checked with a pure fp16 `cross` and we fail the new test with this implementation also: ```c half3 __attribute__((overloadable)) my_cross(half3 p0, half3 p1) { half3 result; result.x = fma(p0.y,...

As background, the kernel mentioned in the forum post is an OpenCL 2.2 C++ kernel language kernel. In the OpenCL 2.2 C++ kernel language, 3D images are read from and...

> My second response on the original post also tried an OpenCL C kernel with a 2D write_imagei, which doesn't have an image2d_t, int4 overload that I can see. It...

Discussed in the March 5th teleconference: * We're going to require 4D coordinates. * Need to check CTS test coverage. * Need to check SPIR-V validator coverage.