bash-language-server icon indicating copy to clipboard operation
bash-language-server copied to clipboard

Incorrect Hover Documentation Shown

Open hak33m16 opened this issue 4 years ago • 5 comments

When a function is created that has the same name as an executable on a user's path (e.g. something like 'ls'), when you hover over the name of that function at the definition site or wherever it's being used, the man page for that executable is shown

Example:

ls() {
  echo "TEST"
}

ls

Hovering over ls in both of these situations will result in the error I mentioned above happening (worth noting that this doesn't break the "Go to Definition" feature, so it's really just an aesthetic issue)

hak33m16 avatar Feb 04 '21 19:02 hak33m16

Good catch. Let me know if you want to help fix the issue.

skovhus avatar Feb 04 '21 19:02 skovhus

Sure, I'd definitely be willing to take a crack at it this weekend

hak33m16 avatar Feb 04 '21 20:02 hak33m16

Sure, I'd definitely be willing to take a crack at it this weekend

Thanks, that would be great! 👏

skovhus avatar Feb 04 '21 20:02 skovhus

Do you have any form of IRC/Discord/communication channel for this project I could contact you through, in case I get stuck on something?

hak33m16 avatar Feb 04 '21 20:02 hak33m16

We do not have any forum/channels, but feel free to ping me here or in a draft PR. :)

skovhus avatar Feb 04 '21 21:02 skovhus