solid_queue icon indicating copy to clipboard operation
solid_queue copied to clipboard
verified publisher icon basecamp

Flaky tests

Open p-schlickmann opened this issue 5 months ago • 3 comments

Hi team,

I understand the current state of the test suite is not ideal - some tests are flaky.

I'd love to help improve this. Ensuring test reliability should be a top priority, especially for an open-source tool that's the default queue mechanism in Rails 8.

@rosa I created this issue so we can discuss it further - do you have any advice or suggestions before I start digging in?

Thanks!

p-schlickmann avatar Jul 21 '25 14:07 p-schlickmann

Hey @p-schlickmann, yes. All these tests that fork processes and rely on waiting on things to happen elsewhere are quite flaky indeed. I don't have any particular suggestions to start looking, I'm afraid, but any help here would be quite welcome!

rosa avatar Jul 21 '25 15:07 rosa

Looks like the flakiest test after the last improvements is this one:

bin/rails test test/integration/instrumentation_test.rb:306

I tried to make it better in https://github.com/rails/solid_queue/commit/f433a99fd402dd25213db445dbcebef29617aa8c but that didn't work so well. I'll look into it later.

rosa avatar Jul 23 '25 08:07 rosa

Yea I noticed test/integration/processes_lifecycle_test.rb is also quite flaky - I'm working on it

p-schlickmann avatar Jul 23 '25 19:07 p-schlickmann